Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out#8113

Open
chriscanin wants to merge 1 commit intomainfrom
chris/fix-apple-signin-entitlement-unconditional
Open

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
chriscanin wants to merge 1 commit intomainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin
Copy link
Member

@chriscanin chriscanin commented Mar 18, 2026

Summary

Fixes #8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json
{
  "plugins": [
    ["@clerk/expo", { "appleSignIn": false }]
  ]
}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 18, 2026 4:24pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 18, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check ✅ Passed The PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check ✅ Passed All changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscanin chriscanin self-assigned this Mar 18, 2026
Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants